Add ResidualVisitor to compute residuals #1388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta-only-op add count in data scan and test in catalog sql
kevinjqliu
reviewed
Nov 28, 2024
|
Question: Does it make sense to expose this as the |
…-count Residual Evaluator with test
* added residual evaluator in plan files * tested counts with positional deletes * merged main
* added residual evaluator in plan files * tested counts with positional deletes * merged main * implemented batch reader in count * breaking integration test * fixed integration test * git pull main * revert * revert * revert test_partitioning_key.py * revert test_parser.py * added residual evaluator in visitor * deleted residual_evaluator.py * removed test count from test_sql.py * ignored lint type * fixed lint * working on plan_files * type ignored * make lint
|
Hi @Fokko @kevinjqliu @gli-chris-hao , I have implemented these suggestions with my best understanding.
It would be helpful to get fresh review |
Fokko
changed the title
Fokko
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This is great @tusharchou Thanks for working on this. I left some comments, but this is a great start 🚀
pyiceberg/expressions/visitors.py
Outdated
Comment on lines
1786
to
1790
| val = term.eval(self.struct) | ||
| if val is not None: | ||
| return self.visit_true() | ||
| else: | ||
| return self.visit_false() |
There was a problem hiding this comment.
Java takes a different approach and checks for NaN:
Suggested change
| val = term.eval(self.struct) | |
| if val is not None: | |
| return self.visit_true() | |
| else: | |
| return self.visit_false() | |
| if isnan(term.eval(self.struct)): | |
| return self.visit_true() | |
| else: | |
| return self.visit_false() |
There was a problem hiding this comment.
This change is causing a type casting problem as term.eval() returns a L with can be of typre str, bytes, UUID with isnan doesn't support
pyiceberg/expressions/visitors.py:1799: error: Argument 1 to "isnan" has incompatible type "str"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
pyiceberg/expressions/visitors.py:1799: error: Argument 1 to "isnan" has incompatible type "bytes"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
pyiceberg/expressions/visitors.py:1799: error: Argument 1 to "isnan" has incompatible type "UUID"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
pyiceberg/expressions/visitors.py:1805: error: Argument 1 to "isnan" has incompatible type "str"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
pyiceberg/expressions/visitors.py:1805: error: Argument 1 to "isnan" has incompatible type "bytes"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
pyiceberg/expressions/visitors.py:1805: error: Argument 1 to "isnan" has incompatible type "UUID"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
There was a problem hiding this comment.
Hi@Fokko, I would require some help here.
There was a problem hiding this comment.
I think we need to help mypy here a bit:
Suggested change
| val = term.eval(self.struct) | |
| if val is not None: | |
| return self.visit_true() | |
| else: | |
| return self.visit_false() | |
| val = term.eval(self.struct) | |
| if isinstance(val, SupportsFloat) and isnan(val): | |
| return self.visit_true() | |
| else: | |
| return self.visit_false() |
The nan check will only be done on float and double columns, but mypy doesn't know that, so we have to help it a bit :)
* added residual evaluator in plan files * tested counts with positional deletes * merged main * implemented batch reader in count * breaking integration test * fixed integration test * git pull main * revert * revert * revert test_partitioning_key.py * revert test_parser.py * added residual evaluator in visitor * deleted residual_evaluator.py * removed test count from test_sql.py * ignored lint type * fixed lint * working on plan_files * type ignored * make lint * explicit delete files len is zero * residual eval only if manifest is true * default residual is always true * used projection schema * refactored residual in plan files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue: Count rows as a metadata-only operation #1223